getdown
getdown copied to clipboard
threerings
No corner icon on first install.
I just wrote my first installer for Getdown.
I bundled my icon with my installer and included it in the getdown.txt file, yet no corner icon is shown.
I thought maybe I had done something wrong, but when I checked something well-done like Spiral Knights, I noticed the same thing.
On the initial install, no icon.
However on subsequent launches the corner icon does show.
The icon has to be in the install directory at the time Getdown starts for it to be used. This means for the first run, since none of the files have yet been downloaded, no icon is available for use.
You can include the icon in your installer so that you install the icon, a getdown.txt and getdown.jar so that it works the first time the app is launched. We usually do this with the UI background image as well, but presumably someone just forgot to include the .ico file in the SK installer.
On Fri, Aug 25, 2017 at 8:41 PM, TurekBot [email protected] wrote:
I just wrote my first installer https://github.com/TurekBot/getdownwindowsinstaller for Getdown.
I bundled my icon with my installer and included it in the getdown.txt file, yet no corner icon is shown.
I thought maybe I had done something wrong, but when I checked something well-done like Spiral Knights, I noticed the same thing.
On the initial install, no icon. [image: No Corner Icon] https://camo.githubusercontent.com/27db11cde06397aa237708afb154428f2a4e7572/68747470733a2f2f692e696d6775722e636f6d2f4937535a3767442e706e67
However on subsequent launches the corner icon does show.
[image: On subsequent launches the corner icon does show] https://camo.githubusercontent.com/27b33aefbd58fc5cbeab49a19c5d0582e4f8236a/68747470733a2f2f692e696d6775722e636f6d2f51794b65576f782e706e67
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/threerings/getdown/issues/86, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL-9MMFwmg8fDqQuKPZdixqxRrcQdvFks5sb5P1gaJpZM4PDVtj .
-- -- [email protected]
Hrm, looking at the Github project you linked to, it seems that your .nsis file does install the icon file. Perhaps you are installing a stub getdown.txt file? In that case, it could be that the app launches, sees no icon config in the stub getdown.txt file, downloads the real getdown.txt file (which has the icons), but by that time it has already created the window, so it doesn't go back to try to reinstate icon files that previously were not configured.
You can put a stub icon configuration in your stub getdown.txt to reference the pre-installed icon images to cause things to work on the first run.
On Fri, Aug 25, 2017 at 8:41 PM, TurekBot [email protected] wrote:
I just wrote my first installer https://github.com/TurekBot/getdownwindowsinstaller for Getdown.
I bundled my icon with my installer and included it in the getdown.txt file, yet no corner icon is shown.
I thought maybe I had done something wrong, but when I checked something well-done like Spiral Knights, I noticed the same thing.
On the initial install, no icon. [image: No Corner Icon] https://camo.githubusercontent.com/27db11cde06397aa237708afb154428f2a4e7572/68747470733a2f2f692e696d6775722e636f6d2f4937535a3767442e706e67
However on subsequent launches the corner icon does show.
[image: On subsequent launches the corner icon does show] https://camo.githubusercontent.com/27b33aefbd58fc5cbeab49a19c5d0582e4f8236a/68747470733a2f2f692e696d6775722e636f6d2f51794b65576f782e706e67
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/threerings/getdown/issues/86, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL-9MMFwmg8fDqQuKPZdixqxRrcQdvFks5sb5P1gaJpZM4PDVtj .
-- -- [email protected]
@vatsal22, thanks for your pull request. Can you show a small example of how this fixes the problem? Then I'll close this issue.