getdown icon indicating copy to clipboard operation
getdown copied to clipboard

Plans for Java 9 Jigsaw (modules) support?

Open Halahala1993 opened this issue 5 years ago • 5 comments

I am trying to build an installer approach of using Getdown through Jlink that would include a runtime.

Are there any plans to modularize Getdown and possibly it's dependencies including Samskivert.jar.

Halahala1993 avatar Aug 22 '18 19:08 Halahala1993

We can certainly provide a module descriptor file for the main Getdown jar file. But Getdown bundles its dependencies internally (and uses Proguard to rename and minify them), so it wouldn't really provide any particular benefits.

The Getdown code is mainly used as a standalone Java app that updates and launches another app, but in some cases it is useful to have Getdown itself as a dependency of the app being launched, so having it be a module for that use case could be useful.

samskivert avatar Aug 22 '18 19:08 samskivert

I tried to inject a module descriptor into Getdown, but when building the custom JRE, jlink required all dependent jars also to be modules and not automatic modules.

Halahala1993 avatar Aug 22 '18 19:08 Halahala1993

I just took a stab at properly modularizing Getdown but there are a bunch of challenges.

I have overcome most of them but Proguard is causing trouble. It has a bug handling module-info class files which is fixed but not released, so I want to wait for Proguard 6.1 to come out before I fool around with this more.

samskivert avatar Aug 22 '18 20:08 samskivert

Check out my project update4j for a fully modular updater.

mordechaim avatar Jul 30 '19 16:07 mordechaim

ProGuard appears to be up to version 7.2.2. Has a newer version been adopted? Will the modules work now? (Not that I am in need, just wondered if this issue can be closed relatively easily.)

maeichris avatar Oct 25 '22 14:10 maeichris