bs-nice
bs-nice copied to clipboard
threepointone
css-in-reason
I am using [reason-scripts](https://github.com/reasonml-community/reason-scripts) to build my app and when I create a production build I encountered the following error. ``` yarn run v1.3.2 $ react-scripts build Creating an optimized...
Hashtbl.hash has a bunch of problems, including taking only n significant values to compute hash, and bucklescript ignoring fractional values when computing. redo.
There's a few things we can do to optimise allocations. 1. Avoid `concat` [here](https://github.com/threepointone/bs-nice/blob/master/src/nice.re#L952) 2. Same [here](https://github.com/threepointone/bs-nice/blob/master/src/nice.re#L928) 3. Use arrays instead of lists. Afaik there's no need to use any...
because of the way we implement nodes of the parsed tree as plain variants, and a giant string_of_style function, most of the unused strings won't get eliminated in a final...
currently inlines with [%bs.raw] https://github.com/threepointone/bs-nice/blob/98611e1aba32a7be3049715900fca2ef64ca256f/src/nice.re#L901
Polymorphic list hash, hashes based on the first ten elements(!!!). Therefore it's super easy to introduce an undebuggable bug if you create two lists with the same 10 first elements.
eg - ```css @media screen { .css-1X8pjt { display: block; color: green; } } @media screen { .css-1X8pjt:hover { color: orange; font-weight: bold; overflow: hidden; } } @media screen {...