zos icon indicating copy to clipboard operation
zos copied to clipboard

substrate-client integration tests

Open muhamadazmy opened this issue 3 years ago • 4 comments

Changes on the grid types always break the code of the client (specially the get operations) so we need some integration tests that we can run against any environment to do "get" on all types.

muhamadazmy avatar Aug 17 '22 16:08 muhamadazmy

can this be a good issue for interns to workon?

xmonader avatar Aug 17 '22 19:08 xmonader

I was rethinking this one actually. The main problem is that sometimes types changes on the grid but because the changes don't reflect in the data structures in this repo it keeps building but fails to decode the structures. So we actually need 2 things here:

  • Generation of types from the grid metadata
  • Basic integration tests for all the getters functions to make sure Get operations won't fail. This won't be easy also because u won't grantee that an object with specific id exists on the grid (deleted by owner, etc...) and we shouldn't mock the grid (won't be easy anyway)
    • what about extrinsics ?

IMHO. what the interns can do is basically generating Go types from substrate metadata. I actually don't know if something like that already exists (it exists for rust) so may be researching should be part of the job.

muhamadazmy avatar Aug 18 '22 07:08 muhamadazmy

The actual issue is here https://github.com/threefoldtech/substrate-client/issues/35

muhamadazmy avatar Aug 30 '22 13:08 muhamadazmy

@xmonader can u assign to Eslam please, i don't know her github user.

muhamadazmy avatar Sep 02 '22 07:09 muhamadazmy