tfchain
tfchain copied to clipboard
chore(polkadot): upgrade to v1.1.0
Description
- [x] Upgrade to Polkadot v1.1.0
- [x] remove
try-runtimefrom node cli - [x] add type
MaxNominatorstopallet_grandpa::Config - [x]
grandpa: avoid importing unnecessary justifications - [x]
vec,Vec,Box,Zerowere removed fromframe_benchmarking - [x]
Dispatchable,DispatchError,bounded_vecwere removed fromframe_support - [x] add
sp-weightsdependency to get access toWeight - [x] change
RuntimeDebugtopallet_prelude::RuntimeDebug - [x] add
logdependency topallet-tft-bridge - [x] add
sp-state-machinedependency tosubstrate-validator-setto getBasicExternalities
- [x] remove
Related Issues:
- Closes #903
Checklist:
Please delete options that are not relevant.
- [x] My commits follow this conventional commits guide.
After running:
try-runtime --runtime ./target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.compressed.wasm on-runtime-upgrade live --uri wss://tfchain.dev.grid.tf:443/ws
I have such result:
triggered here by the pallet_session_historical migration to v1 which returns <T as frame_system::Config>::BlockWeights::get().max_block
But not sure it is a big deal in our case since weight was excessively inflated for some safety reason I guess.
After running:
try-runtime --runtime ./target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.compressed.wasm on-runtime-upgrade live --uri wss://tfchain.dev.grid.tf:443/wsI have such result:
triggered here by the
pallet_session_historicalmigration to v1 which returns<T as frame_system::Config>::BlockWeights::get().max_blockBut not sure it is a big deal in our case since weight was excessively inflated for some safety reason I guess.
To my understanding this migration toke slight longer than ref time ? how it could bad if ran against mainnet state? could you check?
~~I'm having trouble getting past this error in this branch when attempting to build it. Any idea?~~
error: no matching package named `bandersnatch_vrfs` found
location searched: https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b
required by package `sp-core v21.0.0 (https://github.com/paritytech/polkadot-sdk?tag=polkadot-v1.1.0#f60318f6)`
... which satisfies git dependency `sp-core` (locked to 21.0.0) of package `tfchain v2.8.1 (/home/sameh/Projects/tfchain/substrate-node/node)`
Update: Never mind, got it to work.
There isn't any runtime migration required to update to Polkadot v1.1.0, right?
LGTM Thank you @renauter
There isn't any runtime migration required to update to Polkadot v1.1.0, right?
When executing try-runtime I don't have log of any storage version incompatibility version like we had previously here
Also I checked for eventual required migrations in Polkadot v1.1.0 analysis
https://forum.polkadot.network/t/polkadot-release-analysis-v1-1-0/3988#runtime-migrations-3
and there are only some migrations for pallet-contracts which is not in our dependency tree.
So we should be good on migration side
