tfchain icon indicating copy to clipboard operation
tfchain copied to clipboard

chore(polkadot): upgrade to v1.1.0

Open renauter opened this issue 2 years ago • 2 comments

Description

  • [x] Upgrade to Polkadot v1.1.0
    • [x] remove try-runtime from node cli
    • [x] add type MaxNominators to pallet_grandpa::Config
    • [x] grandpa: avoid importing unnecessary justifications
    • [x] vec, Vec, Box, Zero were removed from frame_benchmarking
    • [x] Dispatchable, DispatchError, bounded_vec were removed from frame_support
    • [x] add sp-weights dependency to get access to Weight
    • [x] change RuntimeDebug to pallet_prelude::RuntimeDebug
    • [x] add log dependency to pallet-tft-bridge
    • [x] add sp-state-machine dependency to substrate-validator-set to get BasicExternalities

Related Issues:

  • Closes #903

Checklist:

Please delete options that are not relevant.

renauter avatar Nov 30 '23 13:11 renauter

After running:

try-runtime --runtime ./target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.compressed.wasm on-runtime-upgrade live --uri wss://tfchain.dev.grid.tf:443/ws

I have such result:

image

triggered here by the pallet_session_historical migration to v1 which returns <T as frame_system::Config>::BlockWeights::get().max_block

But not sure it is a big deal in our case since weight was excessively inflated for some safety reason I guess.

renauter avatar Dec 12 '23 02:12 renauter

After running:

try-runtime --runtime ./target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.compressed.wasm on-runtime-upgrade live --uri wss://tfchain.dev.grid.tf:443/ws

I have such result:

image

triggered here by the pallet_session_historical migration to v1 which returns <T as frame_system::Config>::BlockWeights::get().max_block

But not sure it is a big deal in our case since weight was excessively inflated for some safety reason I guess.

To my understanding this migration toke slight longer than ref time ? how it could bad if ran against mainnet state? could you check?

sameh-farouk avatar Dec 19 '23 14:12 sameh-farouk

~~I'm having trouble getting past this error in this branch when attempting to build it. Any idea?~~

error: no matching package named `bandersnatch_vrfs` found
location searched: https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b
required by package `sp-core v21.0.0 (https://github.com/paritytech/polkadot-sdk?tag=polkadot-v1.1.0#f60318f6)`
    ... which satisfies git dependency `sp-core` (locked to 21.0.0) of package `tfchain v2.8.1 (/home/sameh/Projects/tfchain/substrate-node/node)`

Update: Never mind, got it to work.

sameh-farouk avatar Aug 23 '24 19:08 sameh-farouk

There isn't any runtime migration required to update to Polkadot v1.1.0, right?

sameh-farouk avatar Aug 25 '24 16:08 sameh-farouk

LGTM Thank you @renauter

sameh-farouk avatar Aug 26 '24 10:08 sameh-farouk

There isn't any runtime migration required to update to Polkadot v1.1.0, right?

When executing try-runtime I don't have log of any storage version incompatibility version like we had previously here

Also I checked for eventual required migrations in Polkadot v1.1.0 analysis https://forum.polkadot.network/t/polkadot-release-analysis-v1-1-0/3988#runtime-migrations-3 and there are only some migrations for pallet-contracts which is not in our dependency tree.

So we should be good on migration side

renauter avatar Aug 26 '24 12:08 renauter