htmlbeautifier icon indicating copy to clipboard operation
htmlbeautifier copied to clipboard

Indent with javascript tag

Open michaelglass opened this issue 2 years ago • 2 comments

allows <%= javascript_tag %>...<%end> to behave like <script>...</script>

I haven't read enough of the whole library to understand the consequences of this PR! It wouldn't surprise me if it is very broken!

Consider this as much a "feature request / issue" as a PR.

... But was easy enough to hack it together so made a PR.

Thanks for your wonderful, relatively lightweight gem.

michaelglass avatar Oct 05 '22 08:10 michaelglass

Sorry I've neglected this for so long! I think the goal is good here, but instead of treating javascript_tag specially, it should probably indent anything within a Ruby do/end block.

I'll leave this PR open as a reminder (and because I'll take the tests).

threedaymonk avatar Feb 13 '24 13:02 threedaymonk

This also needs to ignore tags within tags. Ex

<%= javascript_tag nonce: true do %>
  fetch('<%= root_url %>/cart.json', ...);
<% end %>

gets reformatted to

<%= javascript_tag nonce: true do %>
  fetch('<%= root_url %>
  /cart.json', ...);
<% end %>

ziadsawalha avatar May 13 '24 10:05 ziadsawalha