rollbar-sourcemap-webpack-plugin icon indicating copy to clipboard operation
rollbar-sourcemap-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon thredup

Adding support for retry with backoff

Open GreenGremlin opened this issue 2 years ago • 9 comments

Fixes #73

This PR adds a new option maxRetries which defaults to 0. When a value greater than 0 is passed, the plugin will retry failed uploads, up to the number of maxRetries passed. Each retry is delayed by an exponentially increasing backoff to ensure retries don't inundate a potentially strained server.

GreenGremlin avatar Jun 24 '22 18:06 GreenGremlin

@florrain it looks like you're currently the only member of thredup. Is there any chance you would be able to take a look at this PR?

GreenGremlin avatar Jun 28 '22 17:06 GreenGremlin

@waltjones you appear to be one of the primary contributors to rollbar-cli. so I'm taking a shot in the dark. This project seems to be abandoned. Is there any chance Rollbar might consider either taking over the project, if someone at thredup is willing to transfer it, or maintaining a fork of it?

GreenGremlin avatar Jun 28 '22 18:06 GreenGremlin

@GreenGremlin thanks for the PR. This project isn't abandoned. We will have a look and catch up on some PRs and issues.

brandondoran avatar Jun 28 '22 19:06 brandondoran

@brandondoran awesome! Thank you!

GreenGremlin avatar Jun 28 '22 20:06 GreenGremlin

@brandondoran this PR is ready for another look

GreenGremlin avatar Jul 13 '22 17:07 GreenGremlin

@brandondoran bumping this, in case it fell through the cracks

GreenGremlin avatar Sep 30 '22 20:09 GreenGremlin

Thanks for putting this together, @GreenGremlin and @brandondoran! This is really going to help users cut down on build failures.

jstrater avatar Oct 06 '22 20:10 jstrater

This would be a great addition! Lots of build failures lately that this could easily fix. @brandondoran Any chance you can take another pass? 🙏

imconfused218 avatar Oct 11 '22 16:10 imconfused218

@brandondoran is there any chance you might be able to give this PR another look?

GreenGremlin avatar Aug 29 '23 15:08 GreenGremlin