gocryptotrader
gocryptotrader copied to clipboard
exchanges: OkCoin Update
Selam Everyone
This PR includes comprehensive updates to types, web-socket handlers, wrapper functions, and some endpoint methods. I have conducted live testing on web socket push data handling including the order book. Cleaned up the codebase by removing the okcoin_convert.go file and replaced timestamp information with 'convert.ExchangeTime' for improved clarity and efficiency.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an x
in []
as the item is complete.
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How has this been tested
- [x] go test ./... -race
- [x] golangci-lint run
- [x] Test X
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented on my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally and on Github Actions with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Lovely tACK. Thanks Sam! 🚀
🙏🏽🫡
Codecov Report
Attention: Patch coverage is 66.33166%
with 67 lines
in your changes are missing coverage. Please review.
Project coverage is 35.87%. Comparing base (
954aa02
) to head (80e9b3c
). Report is 13 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1436 +/- ##
========================================
Coverage 35.87% 35.87%
========================================
Files 411 410 -1
Lines 177444 177302 -142
========================================
- Hits 63651 63611 -40
+ Misses 106029 105942 -87
+ Partials 7764 7749 -15
Files | Coverage Δ | |
---|---|---|
exchanges/okcoin/okcoin_ratelimit.go | 46.72% <100.00%> (ø) |
|
exchanges/okcoin/okcoin_types.go | 100.00% <100.00%> (+58.57%) |
:arrow_up: |
exchanges/okcoin/okcoin_wrapper.go | 30.33% <66.66%> (+0.40%) |
:arrow_up: |
exchanges/okcoin/okcoin_ws_trade.go | 0.00% <0.00%> (ø) |
|
exchanges/okcoin/okcoin_websocket.go | 39.01% <62.50%> (-1.76%) |
:arrow_down: |
exchanges/okcoin/okcoin.go | 15.82% <20.00%> (ø) |
I couldn't get this error message whenever I tried. The rate limit value I used is also correct!