exchanges: Add dYdX support

[samuael]

PR Description

This pull request Included a code implementation for the dYdX exchange version 3; with REST and web-socket support. All the Websocket and Wrapper functions are tested. My code follows the style guidelines of other exchanges of GCT. Fixed some errors with the help of golangci-lint. Endpoint methods that have no support from the GCT wrapper are also implemented for future use. Fixes # (issue)

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] This change requires a documentation update

How has this been tested

• [x] go test ./... -race
• [x] golangci-lint run
• [x] Test X

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally and on Github Actions/AppVeyor with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[samuael]

Of course, this exchange requires several updates, but the reason I created this pull request earlier is to let you help me in doing some functionalities, as this exchange is a little bit different from the others.

On Sun, Feb 19, 2023 at 11:25 PM Scott @.***> wrote:

@.**** requested changes on this pull request.

Thank you for opening another PR! I was going to get cracking reviewing this, however I ran into immediate problems that made me stop.

• You have not added the exchange to the exchange manager
• This suggests that you have not run this exchange via the application to validate easy errors such as websocket connection/authorisation/pingpong management or any obvious wrapper problems that come up via the syncher.
• After adding the exchange to the manager, there are errors that show that the implementation does not match the exchange interface under /exchanges/interfaces.go IBotExchange
• There are tests that are failing

So I'm a bit concerned that this hasn't fully been tested before being put up for review and might need a bit more attention before we review it again.

— Reply to this email directly, view it on GitHub https://github.com/thrasher-corp/gocryptotrader/pull/1134#pullrequestreview-1304900707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOJSZ22QKQ6BD7L4LPLY53WYKTUZANCNFSM6AAAAAAUZNOMXQ . You are receiving this because you were assigned.Message ID: @.***>

[samuael]

But I will let you know when I think the exchange is ready for review next time. Since I am going to be adding some updates to it.

On Mon, Feb 20, 2023 at 6:23 AM samuael adnew @.***> wrote:

Of course, this exchange requires several updates, but the reason I created this pull request earlier is to let you help me in doing some functionalities, as this exchange is a little bit different from the others.

On Sun, Feb 19, 2023 at 11:25 PM Scott @.***> wrote:

@.**** requested changes on this pull request.

Thank you for opening another PR! I was going to get cracking reviewing this, however I ran into immediate problems that made me stop.

• You have not added the exchange to the exchange manager
• This suggests that you have not run this exchange via the application to validate easy errors such as websocket connection/authorisation/pingpong management or any obvious wrapper problems that come up via the syncher.
• After adding the exchange to the manager, there are errors that show that the implementation does not match the exchange interface under /exchanges/interfaces.go IBotExchange
• There are tests that are failing

So I'm a bit concerned that this hasn't fully been tested before being put up for review and might need a bit more attention before we review it again.

— Reply to this email directly, view it on GitHub https://github.com/thrasher-corp/gocryptotrader/pull/1134#pullrequestreview-1304900707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOJSZ22QKQ6BD7L4LPLY53WYKTUZANCNFSM6AAAAAAUZNOMXQ . You are receiving this because you were assigned.Message ID: @.***>