winctl icon indicating copy to clipboard operation
winctl copied to clipboard

make winctl compatible with electron v20 and above

Open Christian1984 opened this issue 2 years ago • 0 comments

According to various reports there are currently two major issues that cause electron apps (after v20) to conflict with native modules.

1.) deprecated AccessorSignatures as per https://github.com/nodejs/nan/pull/943 - This issue is fixed by a fix in the nan module, it hasn't been merged and released yet. I tested it by installing nan from https://github.com/weedz/nan/commit/a679b69b92e1997f6b40f1d3981a58a0021e1b99 and winctl builds with this patch.

2.) CreationContext is no longer supported. According to https://github.com/WiseLibs/better-sqlite3/issues/858#issuecomment-1228218306 this can be fixed by replacing CreationContext() with GetCreationContext().ToLocalChecked().

The latter was implemented here. With the upcoming release of a new nan version the first issue should "fix itself" :-) winctl should then be fully compatible with electron v20 and newer.

Christian1984 avatar Sep 15 '22 13:09 Christian1984