thcrap
thcrap copied to clipboard
Touhou Community Reliant Automatic Patcher
For these I propose the following: - Set up issue templates for bugs, enchantments, new game support, etc. - Improve labels. - Create labels for each project / area. -...
The thcrap_loader process keeps running after closing the game on Wine. The issue is present since the [2023-08-17](https://github.com/thpatch/thcrap/releases/tag/2023-08-17) release and affects all versions of Wine/Proton. From my debugging, this thread...
In https://github.com/thpatch/thcrap/blob/fd10f94d867fde403ef9008e3534a2b2e3d16274/thcrap_configure_v3/ThcrapDll.cs#L180C9-L180C9 , we assume that the members of the `game_search_result` struct will contain only ASCII characters, outside of `path` which is declared as `IntPtr` and converted manually. But `description`...
On wine with thcrap_configure_v3 (and likely with the legacy configure as well), the recursive games search doesn't seem to work: there are reports of people needing to select each game's...
Many people in the #support channel of thcrap don't like to have their username seen. They'll often edit their screenshots to hide their username in the file explorer. I'm guessing...
To reproduce this issue: * Make a network folder with a Touhou game in it * Make old thcrap_configure scan for games in that folder and generate configurations Then observe...
When the id in patch.js is wrong, thcrap_configure_v3 crashes at this line: https://github.com/thpatch/thcrap/blob/ffc4277150946c8a33695b44cd272855e47dd9b6/thcrap_configure_v3/MainWindow.xaml.cs#LL105C15-L105C15 knownPatches contains the patch names from the various repo.js files, and the `id` variable comes from patch_bootstrap...
`11>d:\repos\thcrap\thcrap\thcrap\src\runconfig.cpp(361): warning C4834: discarding return value of function with 'nodiscard' attribute` Also, I feel like the warning about digital signing doesn't have to happen every project... ``` 16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning :...
And character names for main scoretable.