thcrap
thcrap copied to clipboard
Thcrap crashes in startup
Excuse me if I speak badly in English, I use a translator
I have already tried many times but the program crashes when I try to start it, I have already deleted the thcrap_update.dll and I have already downloaded other versions, I just don't know what's going on...
Hotfix done on our server, it should work now. I keep the issue open because we don't want to crash when this kind of error happens.
It crashes while reading a repo.js file downloaded from a server, because this server returns a json file in case of error, which looks nothing like ours. Yet we still try to use it like a normal repo.js, and it seems we have no error checks on that. Quick fix by zero in https://github.com/thpatch/thcrap/commit/6a6cfde1174c995b768a57185638edc0fe09a484 , we may want to check more fields like that (or make sure that every other field can be null).
Not sure it is the same issue or not.
The tool keep crash while checking the update.
(no stopped to response
dialog, the window just disappear)