urlwatch icon indicating copy to clipboard operation
urlwatch copied to clipboard

Wait for selector?

Open yuis-ice opened this issue 1 year ago • 1 comments

As #548, some websites don't load properly (one serious example would be jp.mercari.com/) with just a wait_until. I think it'd be better to enable users to use wait_for to wait for a selector, or enables users to inject/eval a custom JavaScript script within the filter chain so it allows users much more capability more than the waiting issue. Thanks.

yuis-ice avatar May 15 '23 05:05 yuis-ice

With urlwatch 2.28, the docs say: https://urlwatch.readthedocs.io/en/latest/jobs.html#browser

wait_until: Either load, domcontentloaded, networkidle, or commit (see Advanced Topics)

See also: Configuring how long browser jobs wait for pages to load

Related docs: https://dev.to/checkly/avoiding-hard-waits-in-playwright-and-puppeteer-272

thp avatar May 17 '23 10:05 thp

Have put a very naive implementation in as #810

Jamstah avatar Mar 22 '24 15:03 Jamstah