urlwatch icon indicating copy to clipboard operation
urlwatch copied to clipboard

Matrix client dependency (migrate to matrix-nio)

Open pandrews255 opened this issue 4 years ago • 2 comments

When I look at the github page for the dependency of matrix_client at https://github.com/matrix-org/matrix-python-sdk it reads:

We strongly recommend using the matrix-nio library rather than this sdk. It is both more featureful and more actively maintained.

Is there a plan to change to the matrix-nio library as a client dependency?

pandrews255 avatar Jul 29 '20 03:07 pandrews255

It also says:

This sdk is currently lightly maintained without any person ultimately responsible for the project. Pull-requests may be reviewed, but no new-features or bug-fixes are being actively developed.

This might also mean it's stable and mature, which isn't too bad (e.g. no API breaks, ...) compared to the other solution (but I haven't checked out both projects, so I don't know and matrix-nio maintainers might be super disciplined with API stability even while new features are developed).

If anybody provides a pull request that replaces matrix-python-sdk with matrix-nio, I'm happy to review and merge it, but other than that I don't really see the need to quickly replace the current implementation with something else (until it starts breaking, and even then, maybe someone fixes matrix-python-sdk and it's good for another few years).

If/when we use more asyncio in urlwatch, migrating to matrix-nio might make more sense, but just like nosetests to pytest migrations, as long as it isn't broken, no need to rush migration (IMHO).

thp avatar Jul 29 '20 15:07 thp

Spoken like someone who's been doing this a lot longer than me. Thanks for the detailed information.

I was interested in the e2ee support by nio on it's page. That's out of my needed use case currently, but might be something desirable if/when a migration happens.

pandrews255 avatar Jul 30 '20 18:07 pandrews255