ketherhomepage icon indicating copy to clipboard operation
ketherhomepage copied to clipboard

Publish flow: Add a client-side warning about unsupported schemes

Open shazow opened this issue 8 years ago • 2 comments

Right now we just check if links are missing ://.

For images, in case the publisher uses file:// out of confusion, would be good to warn them about it (and any other scheme not in our whitelist).

Relevant code example for links is here: https://github.com/thousandetherhomepage/ketherhomepage/blob/master/src/Publish.vue#L80

I think our whitelist is effectively: http, https, ipfs, bzz

Something like

Unrecognized scheme: Your image URL should probably be something that starts with https://..., you may need to upload it to an image host like imgur.

shazow avatar Oct 08 '17 16:10 shazow

@mveytsman I suspect the latest file:// image was not a malicious attempt, just confusion. Let's add something to the client side. (I might do this later if I feel better, or self-assign if you feel like messing around with the frontend.)

shazow avatar Oct 08 '17 16:10 shazow

Should the UI just warn you?

Max

On Oct 8, 2017, at 12:30 PM, Andrey Petrov [email protected] wrote:

@mveytsman I suspect the latest file:// image was not a malicious attempt, just confusion. Let's add something to the client side. (I might do this later if I feel better, or self-assign if you feel like messing around with the frontend.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mveytsman avatar Oct 08 '17 18:10 mveytsman