talisman icon indicating copy to clipboard operation
talisman copied to clipboard

Using "allowed_patterns" does not work with file paths that contain wildcards

Open second-frank opened this issue 2 years ago • 0 comments

Describe the bug

Using allowed_patterns in the fileignoreconfig section does not work with file names/paths that contain wildcards.

To Reproduce

With .talismanrc config:

fileignoreconfig:
- filename: 'sub-folder/*.css'
  ignore_detectors: [filecontent]
- filename: 'sub-folder/*.json'
  allowed_patterns: [dataKey]

Steps to reproduce the behavior:

  1. mkdir -p sub-folder
  2. echo '@keyframes{opacity:0;transform:scale(1)}' > sub-folder/test.css
  3. echo '{"dataKey":"foobar"}' > sub-folder/test.json
  4. talisman --pattern '**/*'

Only the css file is ignored, while the json file is still reported.

Expected behavior

The filename pattern for allowed_pattern definitions should be interpreted in the same way as for ignore_detectors.

Desktop (please complete the following information):

  • OS: Ubuntu 22.04 / Windows 10 (GitBash)
  • Talisman version: 1.30.0

Frank Seidel [email protected], Mercedes-Benz Tech Innovation GmbH
Provider Information

second-frank avatar Feb 22 '23 12:02 second-frank