talisman icon indicating copy to clipboard operation
talisman copied to clipboard

talisman breaks when gitconfig.diff.noprefix=true

Open revolunet opened this issue 3 years ago • 0 comments

Describe the bug Talisman 1.28.0 (and below) silently fails if you have this setting in your ~/.gitconfig:

[diff]
  noprefix = true

To Reproduce Add the GIT setting, try to to run talisman pre-commit hook

This result in :

Talisman Scan: 0 <...........................................................................................................................................................................................................................................................................> ?%
Talisman done in 68.989268ms
 TALISMAN >>>>   Check passed!!!!

You can see the progressbar is broken (?%) that's because talisman cant handle the git diff output

Also, errored files are not detected and commited

Expected behavior

Talisman should detect or override such userland setting or warn the user.

revolunet avatar Jul 27 '22 09:07 revolunet