talisman icon indicating copy to clipboard operation
talisman copied to clipboard

Configuring custom severities not working with pre-push

Open carhartl opened this issue 3 years ago • 1 comments

Describe the bug I don't seem to be able to make use of custom severities when using talisman within a pre-push hook.

To Reproduce Steps to reproduce the behavior:

cat <<EOF > .talismanrc
custom_severities:
  - detector: HexContent
    severity: low
threshold: medium
EOF
echo 5ba6ef628df0b7c21e8d6bf6235d32914effa0d0de62d8ea96678316a1d5d32b > foo.txt
git commit -m "Test"
echo "refs/heads/main HEAD refs/heads/main HEAD^1" | talisman --githook pre-push

(Mimicking a pre-push hook in the last command.)

Output:

Talisman Scan: 3 / 3 <---------------------------------------------------------------------------------> 100.00%

Talisman Report:
+---------+----------------------------------------------------+----------+
|  FILE   |                       ERRORS                       | SEVERITY |
+---------+----------------------------------------------------+----------+
| foo.txt | Expected file to not to contain                    | high     |
|         | hex encoded texts such as:                         |          |
|         | 5ba6ef628df0b7c21e8d6bf6235d32914effa0d0de62d8e... |          |
+---------+----------------------------------------------------+----------+


If you are absolutely sure that you want to ignore the above files from talisman detectors, consider pasting the following format in .talismanrc file in the project root

fileignoreconfig:
- filename: foo.txt
  checksum: 15acfde30d57c8dda5f7b41007a55c446e9d0c79119b77794e48148b7d1a2e2c
version: ""

Talisman done in 51.337541ms

Expected behavior Talisman does not report hex encoded text with high severity, no detections should have been reported respecting the threshold.

Environment:

  • OS: macOS Monterey 12.4
  • talisman 1.26.0

carhartl avatar May 25 '22 06:05 carhartl

Hi, have you found any solution? Thanks!

lizc126 avatar Nov 27 '23 06:11 lizc126