talisman icon indicating copy to clipboard operation
talisman copied to clipboard

Talisman prevented gh-pages script from publishing to GitHub Pages when deploying a simple react app

Open euloong opened this issue 5 years ago • 2 comments
trafficstars

Describe the bug

  • The Create React App documentation advises installing and running gh-pages to publish a simple React app to GitHub Pages: https://create-react-app.dev/docs/deployment/#step-2-install-gh-pages-and-add-deploy-to-scripts-in-packagejson

  • When running yarn deploy the gh-pages script runs but then hangs at the commit stage. This can be seen by running the yarn deploy in debug mode by using NODE_DEBUG=gh-pages yarn deploy

  • As part of my troubleshooting: I manually committed to my repo and encountered the checksum warnings from Talisman, after answering yes to the warnings I was able to manually commit to my repo.

  • I suspected that Talisman was blocking the gh-pages script from committing to GitHub.

  • I uninstalled Talisman and ran the yarn deploy again, this time I was able to successfully deploy my app to GitHub pages.

To Reproduce

Steps to reproduce the behavior:

  1. Have Talisman installed
  2. Create a React app: https://create-react-app.dev/docs/getting-started
  3. Follow the steps to publish to GitHub Pages: https://create-react-app.dev/docs/getting-started (I used yarn but assume same issue will be faced with NPM)
  4. Use yarn deploy in debug mode by using NODE_DEBUG=gh-pages yarn deploy
  5. It will run through the script and stop at the Committing stage

Expected behavior

The gh-pages script should be able to run and publish the app to the GitHub repo and create a gh-pages branch for deployment to GitHub Pages.

Screenshots

Expected Behaviour: gh-pages successful

Desktop:

  • OS: macOS Catalina v 10.15.6
  • Browser: Chrome
  • Version: 84.0.4147.135

euloong avatar Aug 28 '20 11:08 euloong

Did you install talisman with interactive mode enabled by default ? Interactive mode would definitely cause this hanging problem.

svishwanath-tw avatar Aug 28 '20 11:08 svishwanath-tw

I can't remember as I installed it as part of a workshop at work under the direction of the instructor. It does sound like interactive mode was enabled.

I will be able to test this weekend by reinstalling Talisman.

euloong avatar Sep 02 '20 05:09 euloong