cruisecontrol.rb icon indicating copy to clipboard operation
cruisecontrol.rb copied to clipboard

Build Changeset on web-interface looks ugly on ruby1.9.1

Open evtuhovich opened this issue 15 years ago • 6 comments

Build Changeset in web interface looks like this:

[SourceControl::Git::Revision:(0a9cbe11581ec160af7ac152746fc3d006b49244)]

Here a patch to fix it.

diff --git a/app/models/project.rb b/app/models/project.rb
index e1f86d4..8a1d15a 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -267,7 +267,7 @@ class Project
     begin
       if build_necessary?(reasons = [])
         remove_build_requested_flag_file if build_requested?
-        return build(source_control.latest_revision, reasons)
+        return build(source_control.latest_revision, reasons.flatten)
       else
         return nil
       end

evtuhovich avatar Jan 21 '10 08:01 evtuhovich

I believe that this is still true. To fix soon.

bguthrie avatar May 31 '11 15:05 bguthrie

After pulled the the latest source. It seems to be fine with manually requested builds. But not the builds that triggered by an actual push

ywen avatar Jun 24 '11 14:06 ywen

Here's the screenshots:

same commit, the first one was triggered by the real commit:

http://cl.ly/0E3M2l2i3b0i3U3k053F

And this one is triggered manually:

http://cl.ly/2d3y0e1l3n313u3s1Y1g

Thanks

ywen avatar Jun 24 '11 14:06 ywen

That's odd. Thanks very much for contributing the screenshots; I'll re-open.

bguthrie avatar Jun 25 '11 13:06 bguthrie

I'm having a hard time replicating this; is anyone else seeing it?

bguthrie avatar Jul 03 '11 04:07 bguthrie

Just throw in more info: the env is ruby 1.9.2p136, hosted by nginx + passenger 3.0.7

ywen avatar Jul 03 '11 04:07 ywen