cruisecontrol.rb
cruisecontrol.rb copied to clipboard
Build Changeset on web-interface looks ugly on ruby1.9.1
Build Changeset in web interface looks like this:
[SourceControl::Git::Revision:(0a9cbe11581ec160af7ac152746fc3d006b49244)]
Here a patch to fix it.
diff --git a/app/models/project.rb b/app/models/project.rb index e1f86d4..8a1d15a 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -267,7 +267,7 @@ class Project begin if build_necessary?(reasons = []) remove_build_requested_flag_file if build_requested? - return build(source_control.latest_revision, reasons) + return build(source_control.latest_revision, reasons.flatten) else return nil end
I believe that this is still true. To fix soon.
After pulled the the latest source. It seems to be fine with manually requested builds. But not the builds that triggered by an actual push
Here's the screenshots:
same commit, the first one was triggered by the real commit:
http://cl.ly/0E3M2l2i3b0i3U3k053F
And this one is triggered manually:
http://cl.ly/2d3y0e1l3n313u3s1Y1g
Thanks
That's odd. Thanks very much for contributing the screenshots; I'll re-open.
I'm having a hard time replicating this; is anyone else seeing it?
Just throw in more info: the env is ruby 1.9.2p136, hosted by nginx + passenger 3.0.7