build-your-own-radar icon indicating copy to clipboard operation
build-your-own-radar copied to clipboard

The tool appears to be broken in a recent release

Open albertodebortoli opened this issue 1 year ago • 5 comments

At this point I think the tool is just broken, lacking basic error handling and the documentation is off.

The tool just doesn't show any information and hangs forever.

Screenshot 2024-01-24 at 12 54 08

I've used different datasources always obtaining the same behaviour:

  • the one provided at https://www.thoughtworks.com/radar/byor (https://docs.google.com/spreadsheets/d/1QjRbhLcc5OyzYgsmhWaVmSZny_YMGlCcNLdoPss49wA/edit#gid=0)

  • the one provided in the README at https://github.com/thoughtworks/build-your-own-radar (https://docs.google.com/spreadsheets/d/1waDG0_W3-yNiAaUfxcZhTKvl7AUCgXwQw8mdPjCz86U/edit)

  • A custom one hosted publicly on S3 with either MIME type either text/plain or text/csv that used to work in the past. The documentation states "CSV and JSON file: You can also use the URL for a publicly available CSV or JSON file, for instance, one hosted on a public GitHub repository."

I've reproduced the problem by running the v1.1.4 tag on Docker Hub both locally and on AWS (with security groups allowing all traffic).

albertodebortoli avatar Jan 24 '24 13:01 albertodebortoli

Are there any errors logged in your browsers console?

setchy avatar Jan 24 '24 20:01 setchy

@albertodebortoli , we are not able to replicate the issue and the radar is loading for the different sources. Can you give us some more details ?

  1. When starting the docker, are you passing a CLIENT_ID ? This allows us to read the google sheet. The state that you showed in the screenshot happens only if there is an auth issue.
  2. Can you share a screenshot of the browser console ?

yashanandan avatar Jan 25 '24 12:01 yashanandan

I can share the following but stopped investigating and moved to another tool. Hosting a CSV on our GitHub Enterprise or gist will add ?token=<token> to the URL making the radar failing early without any console log nor error on the page. I'm not passing any CLIENT_ID for CSV files.

albertodebortoli avatar Feb 05 '24 14:02 albertodebortoli

The v1.1.4 Docker tag worked fine for me when using either a CSV or JSON datasets hosted in GitHub. Such as:

Google Sheets also worked for me when starting the container with a valid Google CLIENT_ID

setchy avatar Feb 05 '24 15:02 setchy

Docker is not allowed to be used in my org. So, I tried to use nginx locally (had to update the configuration for homebrew Mac) and am running into the same issue (Edit: Only with Google Sheets, because I didn't have the client id configured. I also discovered the Google Sheet must contain only one sheet in the spreadsheet. I originally had multiple sheets. When I used IMPORTRANGE in another spreadsheet to pull all the BYOR related data in from the original spreadsheet, the problem went away.)

mossmana avatar Feb 14 '24 20:02 mossmana