ghost-theme-template icon indicating copy to clipboard operation
ghost-theme-template copied to clipboard

Should default.hbs#L26 path be javascripts/app.js instead of js/app.js?

Open erchaves opened this issue 6 years ago • 2 comments

There seems to be an error here when the template tries to load the empty app.js file. Am I missing something, or should this path be assets/javascripts/app.js?

screen shot 2019-01-22 at 3 24 19 pm

https://github.com/thoughtbot/ghost-theme-template/blob/f2cf5467cca093f685a7bb162263eac35b6c1ad8/default.hbs#L26

erchaves avatar Jan 22 '19 20:01 erchaves

Oh, hmm, I see that the gulp build is creating a css folder in the assets folder, but it's not creating js folder. So I imagine this path is correct, but maybe a 'js' folder is not getting created by the gulpfile as expected? Looking at the gulpfile though, I see where the css folder is created, but not a js folder....

When I run the build, I am getting an error: Failed to load external module @babel/register, could that be related?

screen shot 2019-01-22 at 3 37 51 pm

erchaves avatar Jan 22 '19 20:01 erchaves

+1

danpliego avatar Apr 30 '19 20:04 danpliego