factory_bot icon indicating copy to clipboard operation
factory_bot copied to clipboard

Update docs to require full namespace

Open johnpitchko opened this issue 1 year ago • 8 comments

FactoryBot throws an error when defining factories that refer to classes within modules in non-Rails applications. FactoryBot will work, but the class used by the factory must be explicitly stated in the full namespace.

Address #1459

johnpitchko avatar Jun 28 '24 15:06 johnpitchko

Hey not sure why this is failing. Am I able to resubmit the failing test?

johnpitchko avatar Jul 28 '24 12:07 johnpitchko

Hey not sure why this is failing. Am I able to resubmit the failing test?

The tests are failing on main currently, this is not related to your changes. We're working on fixing it on another PR. And thanks for your submission, I hope we can review and approve soon!

sarahraqueld avatar Jul 29 '24 09:07 sarahraqueld

Hey not sure why this is failing. Am I able to resubmit the failing test?

The tests are failing on main currently, this is not related to your changes. We're working on fixing it on another PR. And thanks for your submission, I hope we can review and approve soon!

Thank you Sarah. Looks like all the tests are passing now 👍 .

johnpitchko avatar Jul 29 '24 19:07 johnpitchko

Hi @sarahraqueld I noticed this is still open. Can we re-execute the checks? I don't believe I can on my end.

johnpitchko avatar Sep 19 '24 05:09 johnpitchko

Thank you, @johnpitchko. Could you rebase against main? That should trigger CI to re-run.

smaboshe avatar Sep 19 '24 05:09 smaboshe

Thank you @smaboshe I rebased as you said, but it seems that the Ruby 3.0 / Rails 6.1 build task is stuck in a loop of Resolving dependencies....

johnpitchko avatar Sep 23 '24 16:09 johnpitchko

Thanks for the rebase. Not sure why that particular build task is failing. We'll take a look.

smaboshe avatar Sep 24 '24 07:09 smaboshe

Hello, I noticed this is still failing and I'm unable to retrigger the build. Can someone investigate or re-trigger please? Thank you.

johnpitchko avatar Oct 18 '24 16:10 johnpitchko