factory_bot icon indicating copy to clipboard operation
factory_bot copied to clipboard

Remove Null Strategy

Open NoahTheDuke opened this issue 3 years ago • 1 comments

I couldn't determine what the purpose of the Null Strategy is, given that it's only used in the AttributesFor#association and simply returns nil. I tried substituting that method call for nil, and everything still works. Seems like it might be worth excising.

NoahTheDuke avatar Feb 11 '21 18:02 NoahTheDuke

Thanks for the addition, this seems like a reasonable change, however, this would require a major release since it is removing an existing feature. Even though probably no one is using the strategy, and it's meant to be private, we can't be sure it won't result in a breaking change. When it's time for a new release we'll take a look at this again.

aledustet avatar Apr 09 '21 16:04 aledustet