capybara-webkit icon indicating copy to clipboard operation
capybara-webkit copied to clipboard

Remove deprecated functionality

Open jferris opened this issue 10 years ago • 6 comments

  • Remove old, non-standard driver methods
  • Remove non-global config methods
  • Remove access to browser instance
  • Remove support commands for removed methods
  • Remove support for Qt 4

jferris avatar Jun 26 '15 17:06 jferris

Resolves #759 and #760.

jferris avatar Jun 26 '15 17:06 jferris

This looks great. I pushed up a few additional changes to the branch. As discussed in #652, we'll now raise an UnhandledModalError when a modal is not explicitly accepted or dismissed. I also removed some dead code. By installing the qt5-default package, there's no need to set the QMAKE environment variable.

mhoran avatar Jun 28 '15 00:06 mhoran

And what about global fonts overriding? I expected it to be removed when update to qt5

https://github.com/thoughtbot/capybara-webkit/blob/master/src/WebPage.cpp#L116

amenzhinsky avatar Aug 15 '15 12:08 amenzhinsky

@amenzhinsky I opened #761 to handle fonts separately from the deprecated functionality.

jferris avatar Aug 17 '15 13:08 jferris

hey @jferris, Are there any plans about a release 2.0?

brunoarueira avatar May 09 '16 22:05 brunoarueira

Are there any plans about a release 2.0?

I think we will likely release a 2.0 that removes deprecated functionality and is somewhat slimmer, but the main priority is currently to figure out what to do now that QtWebKit is deprecated.

jferris avatar May 10 '16 14:05 jferris