Forward output from server pipes ASAP

[ryansouza]

If the webkit server fails to start an error is raised before the output forwarding is set up. Without output forwarding we don't get to see the error from the server making it harder to debug.

[ryansouza]

Ran tests locally in vagrant, success except for the selenium compatibility spec which failed for me on master too

Failures:

  1) Capybara::Webkit compatibility with selenium generates the same events as selenium when filling out forms
     Failure/Error: visit "/"
     Selenium::WebDriver::Error::WebDriverError:
       unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055)
     # ./spec/selenium_compatibility_spec.rb:35:in `block (3 levels) in <top (required)>'
     # ./spec/selenium_compatibility_spec.rb:51:in `instance_eval'
     # ./spec/selenium_compatibility_spec.rb:51:in `events_for_driver'
     # ./spec/selenium_compatibility_spec.rb:46:in `compare_events_for_drivers'
     # ./spec/selenium_compatibility_spec.rb:34:in `block (2 levels) in <top (required)>'

Finished in 8 minutes 19 seconds
1174 examples, 1 failure, 1 pending

[nritholtz]

You need to bump to the latest version of Selenium Webdriver.

This is most likely due to using a newer version of Firefox. On Mar 19, 2015 6:30 PM, "Ryan Souza" [email protected] wrote:

Ran tests locally in vagrant, success except for the selenium compatibility spec which failed for me on master too

Failures:

1. Capybara::Webkit compatibility with selenium generates the same events as selenium when filling out forms Failure/Error: visit "/" Selenium::WebDriver::Error::WebDriverError: unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055)

   ./spec/selenium_compatibility_spec.rb:35:in `block (3 levels) in <top (required)>'

   ./spec/selenium_compatibility_spec.rb:51:in`instance_eval'

   ./spec/selenium_compatibility_spec.rb:51:in `events_for_driver'

   ./spec/selenium_compatibility_spec.rb:46:in`compare_events_for_drivers'

   ./spec/selenium_compatibility_spec.rb:34:in `block (2 levels) in <top (required)>'

Finished in 8 minutes 19 seconds 1174 examples, 1 failure, 1 pending

— Reply to this email directly or view it on GitHub https://github.com/thoughtbot/capybara-webkit/pull/739#issuecomment-83786943 .

[ryansouza]

Success after a bundle update

Finished in 9 minutes 35 seconds
1174 examples, 0 failures, 1 pending

[jferris]

@ryansouza Looks like it's broken on jruby, but only the new specs. If this new change doesn't affect jruby, you can add skip_on_jruby: true to that spec.

[mhoran]

Not sure why this is failing on JRuby; I'd expect it to work. There have been other weird issues with pipes under JRuby in the past, requiring workarounds -- so perhaps that's related. However, it'd be useful for this feature to work under JRuby as well. Perhaps only the test is failing, and it works under normal circumstances?

[twalpole]

Could you please rebase this on master ?