administrate icon indicating copy to clipboard operation
administrate copied to clipboard

Accessibility

Open tysongach opened this issue 7 years ago • 2 comments

I’d love for Administrate to be as accessible, as possible. We’ve done some work in that area already: https://github.com/thoughtbot/administrate/pull/51, https://github.com/thoughtbot/administrate/pull/380, https://github.com/thoughtbot/administrate/pull/410, https://github.com/thoughtbot/administrate/pull/416.

But there is more work to be done. I’m going to use this issue to capture those:

  • [ ] Links must have discernible text (21 violations)
    • Target: body > .app-container > .main-content > .search > .search__clear > a
    • Target: body > .app-container > .main-content > .collection-data > tbody > tr:nth-of-type(1) > .cell-data.cell-data--email > .action-show.table__link-plain (repeat for each row in the data table)
  • [ ] Check a11y of linked table rows; fix the accessible label for table row links.
  • [x] Elements must have sufficient color contrast (76 violations)
    • Target: body > .app-container > .sidebar > .sidebar__list > li:nth-of-type(1) > .sidebar__link.sidebar__link--active (repeat for each blue link)
    • This is the blue link color we use
  • [x] Swap | in page titles, because screen readers read this as “vertical pipe.”

(I’m using the aXe Chrome extension to find these errors)

tysongach avatar Mar 24 '17 17:03 tysongach

Actually, I'm interested on this one. I think this should be fixed. It's not going to happen today or tomorrow, but we should see to it. In the past I've thought a bit about how this table could be improved for accessibility, and I didn't know this ticket was here. The mention to the aXe tool was useful and I have added it to my browser.

I'm going to reopen this if it's ok. And hopefully we'll look into it. One day...

pablobm avatar Feb 11 '21 16:02 pablobm

@pablobm Sounds lovely - I agree we should care about and focus on improving accessibility. I closed because this issue has been open with no movement for so long and I do not have the bandwidth to move it forward I’m also guessing that my list above is now out-of-date (and was non-exhaustive).

tysongach avatar Feb 15 '21 16:02 tysongach