administrate icon indicating copy to clipboard operation
administrate copied to clipboard

Is it possible to not require the image_processing gem?

Open littleforest opened this issue 1 year ago • 1 comments

I was going to see if it made sense to not require this here, and then the Rails app that is using Administrate would require it instead? So then if you are using Administrate but not ActionTest/ActiveStorage you won't be unnecessarily requiring this. Would that work?

Originally posted by @littleforest in https://github.com/thoughtbot/administrate/pull/2411#discussion_r1627970990

littleforest avatar Jun 21 '24 21:06 littleforest

@nickcharlton - Is this actually an issue? We are requiring image_processing in the Gemfile, which only affects the example app, not the Administrate gem. People who use Administrate won't get this gem by default and, as @littleforest says, they will only need it if they use a feature that requires it.

Playing with this quickly now, I can insert an image in an Administrate RichText field without requiring image_processing... which is weird, because if I do the same in the example app, it doesn't quite work. Might be the version of Rails as I'm testing 7.2 (vs 8.0 in the example app).

pablobm avatar Jun 13 '25 16:06 pablobm

…actually, I don't think it really is. I was concerned at the time about introducing more dependencies to the gem itself, but it's not actually doing that.

I'll close it.

nickcharlton avatar Jun 20 '25 14:06 nickcharlton