administrate icon indicating copy to clipboard operation
administrate copied to clipboard

Published 20 hours ago • verified publisher icon thoughtbot

Replace <fieldset> with <section> on show pages

Open Uaitt opened this issue 1 year ago • 0 comments

This PR fixes issue https://github.com/thoughtbot/administrate/issues/2503.

Basically, the <fieldset>s and <legend>s in

  • app/views/administrate/application/show.html.erb
  • app/views/fields/has_one/_show.html.erb

have been replaced by a combination of <section>s, <h1>s and <nav>s. Those new elements have then been styled so that they look exactly like the previous two.

A few screenshots down here 👇

BEFORE THIS CHANGE:

Show page of an object with some grouped and ungrouped attributes. Screenshot 2024-02-01 at 16 57 28

Show page of an object with an has_one field and some other attributes. (Notice the overlapping of borders). Screenshot 2024-02-01 at 16 57 35

AFTER THIS CHANGE:

Show page of an object with some grouped and ungrouped attributes. (Note the difference in width of the grouped block). Screenshot 2024-02-01 at 16 55 51

Show page of an object with an has_one field and some other attributes. (Note that there's no more overlapping). Screenshot 2024-02-01 at 16 55 40

Any feedback is welcomed 😃.

PLEASE NOTE that I am not a frontend dev, if you notice something very stupid or inappropriate in this PR don't be afraid of telling me 😄.

Uaitt avatar Feb 01 '24 16:02 Uaitt