administrate
administrate copied to clipboard
thoughtbot
Add RichText field type
This adds a RichText field type, completing the work started in #1660.
The bullets and numbers aren't showing up in the edit view due to the styling. And the quote does not show up in the show view, I'm assuming also due to styling. Will look into tweaking our CSS so it works better in the demo app.
Will look into the failing tests, some of them are not failing for me locally :(
I had a look. It appears to be order-dependent.
Specifically, when I run en example from spec/generators/routes_generator_spec.rb first, followed by spec/administrate/views/fields/rich_text/_form_spec.rb, the latter fails. Looking into it a bit more, I have narrowed it down to the reset_routes call in the after hook, and in turn to the Rails.application.routes.clear! within it:
https://github.com/thoughtbot/administrate/blob/852b62c73080c78fe219704b45b7dff3ba6e2f94/spec/support/generator_spec_helpers.rb#L38-L41
So it looks that, whatever happens there, it deletes the rails_direct_upload_url helper, making the example fail.
Thoughts?
Are we planning to release this anytime soon - Need this badly for actiontext
@littleforest, are you able to pick up from @seanpdoyle's comments here?
(If not, I can do so!)
@nickcharlton I will see if I can find time to work on this second week of January. Might go faster if I can find time to pair with you or @seanpdoyle .
@littleforest, sorry, only getting back to this one now. How did you get on? Feel free to drop some time on my calendar if you've like to pair on this.
@littleforest the asset changes merged as part of https://github.com/thoughtbot/administrate/pull/2397 have introduced merge conflicts.
If you're interested, I'm willing to give resolving those conflicts a try and force-pushing to this branch.
If not, and you'd rather handle that yourself, that's great too!
I'm willing to give resolving those conflicts a try and force-pushing to this branch
That would be amazing! Thank you.
I've just rebased, and I'll let the tests run before merging this in.
For those following along, it'll go out with our next v1.0 beta release, which I hope to do soon, but I'm behind things at the moment so it might be a while.
Bundle audit is failing because of a security vulnerability in actiontext that we've not merged yet.
And merged. Thanks @sedubois for the original work, and @littleforest for consistently pushing this through!