administrate icon indicating copy to clipboard operation
administrate copied to clipboard

Published 20 hours ago • verified publisher icon thoughtbot

Avoid singularizing namespace in Administrate::ResourceResolver

Open rmachielse opened this issue 3 years ago • 1 comments

See #1931 for details.

rmachielse avatar Sep 16 '22 14:09 rmachielse

@pablobm what do you think? Does this have a chance of getting merged?

rmachielse avatar Sep 21 '22 10:09 rmachielse

@rmachielse - Would you be able to add an example to https://github.com/thoughtbot/administrate/blob/main/spec/lib/administrate/resource_resolver_spec.rb?

pablobm avatar Sep 29 '22 16:09 pablobm

@pablobm would it be okay if I adapt the existing examples to use a plural namespace, like admin/libraries/books?

rmachielse avatar Sep 29 '22 16:09 rmachielse

@rmachielse - Wait, is there another way? :laughing: Go for it!

pablobm avatar Sep 29 '22 22:09 pablobm

@pablobm example added!

rmachielse avatar Oct 03 '22 16:10 rmachielse

Great stuff. Merged!

pablobm avatar Oct 06 '22 12:10 pablobm

Thank you!

rmachielse avatar Oct 06 '22 12:10 rmachielse