administrate icon indicating copy to clipboard operation
administrate copied to clipboard

Correctly detect filters with non-word params

Open cattekin opened this issue 3 years ago • 2 comments

Change the filter regex to return valid filter matches when the filter attribute isn't an ascii word object.

This fixes #2228 as well as allowing using comma separated values when filtering

It shouldn't matter when checking for the existence of a filter whether the characters to the right of the : in the word object contain things like unicode characters or punctuation.

cattekin avatar Sep 08 '22 02:09 cattekin

can you explain more? I do not see related between this and #2252

jubilee2 avatar Sep 20 '22 03:09 jubilee2

can you explain more? I do not see related between this and #2252

sorry, somehow messed up the pasting the issue, the correct one is https://github.com/thoughtbot/administrate/issues/2228

cattekin avatar Sep 20 '22 06:09 cattekin

Looks good. Thank you!

pablobm avatar Oct 06 '22 14:10 pablobm

it's should fixed for #2265

jubilee2 avatar Oct 09 '22 13:10 jubilee2