administrate icon indicating copy to clipboard operation
administrate copied to clipboard

Punditize add support for namespaced models and base policy fallbacks

Open sedubois opened this issue 5 years ago • 6 comments

See https://github.com/thoughtbot/administrate/pull/1591#issuecomment-638218493

Fixes #1332.

sedubois avatar Jun 03 '20 16:06 sedubois

I think this is good. I haven't used this that much, but I think that policy_admin should be removed, as the same functionality can be achieved more naturally from a controller. Unless I'm missing something...?

One problem though is that some people may rely on policy_scope_admin. We should still support it, with a warning, and then remove it in a future version (not the next version).

pablobm avatar Jun 06 '20 17:06 pablobm

@sedubois - As mentioned above, would you be able to add back policy_scope_admin, making it issue a deprecation warning on usage?

pablobm avatar Aug 13 '20 15:08 pablobm

@sedubois, re: @pablobm's comment above, would you be able to do that? I think rebasing too will get rid of the CI errors as those are things I've seen before. Then we should be good to go.

nickcharlton avatar Oct 06 '20 14:10 nickcharlton

@pablobm @nickcharlton I'm still happy to get back to this and a couple of other PRs but I'm a bit swamped ATM. I'd suggest leaving on my plate unless of course someone feels like taking over.

sedubois avatar Oct 06 '20 15:10 sedubois

That's perfect, thanks! I'll leave it to you to get back to when you can.

nickcharlton avatar Oct 06 '20 15:10 nickcharlton

Looks like there's renewed interest on this PR? If someone picks this up and implements the proposed tweaks above, that would be great. For an example of how to issue warnings within Administrate, see: https://github.com/thoughtbot/administrate/blob/master/lib/administrate.rb

pablobm avatar Feb 18 '21 15:02 pablobm

Closing due to lack of activity.

pablobm avatar Apr 18 '23 09:04 pablobm