please icon indicating copy to clipboard operation
please copied to clipboard

Subrepo config errors get silently ignored.

Open cemeceme opened this issue 1 month ago • 0 comments

While tying to figure out why the e2e test for this pull request was failing, I found out that please was silently failing to parse the subrepo, but still continuing as if nothing happened. see this file.

As far as I can tell, this seems to be because errors raised here don't trigger this line to get taken. I don't really know why this seems to be, since err appears to be properly set in the Initialize function, though I don't know enough about how golang handles errors being returned, when not in the return statement.

cemeceme avatar Nov 05 '25 11:11 cemeceme