please icon indicating copy to clipboard operation
please copied to clipboard

FR: Glob blacklist dirs, add whitelist dirs

Open patmaddox opened this issue 1 year ago • 2 comments

I have a repo that pulls in lots of dirs named *.jj and *.git - sometimes these include BUILD files that are invalid for please. I would like please to support globbing blacklist dirs, and allowing whitelist dirs. Currently, please only works on fixed paths.

This would support a "default deny" workflow, while still permitting specific dirs.

I am up for trying to implement this, and want to start the discussion.

[parse]
blacklistdirs = "**/*.git"
blacklistdirs = "**/*.jj"

whitelistdirs = "important-project.git"
whitelistdirs = "important-projects/*.jj"

patmaddox avatar Nov 08 '24 17:11 patmaddox

Hi Pat,

This seems like a reasonable change to make, as long as it can be made in a backwards compatible way. Unfortunately we're unlikely to have time to implement this any time soon, but if you have time to put together a pull request I'd be happy to review it!

toastwaffle avatar Nov 12 '24 09:11 toastwaffle

This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 00:04 stale[bot]