please icon indicating copy to clipboard operation
please copied to clipboard

visibility changes the cache hash

Open izissise opened this issue 2 years ago • 2 comments

Hello,

It would be nice if visibility argument doesn't change the cache hash of a rule, this would speed up relaunch of please after the a visibility error.

Usually a visibility error is thrown after that the rule with an incorrect visibility is build, for some rules it takes quite a bit of time and all that works could be kept if the cache hash not change when the visibility is updated.

Thanks, Hugues

izissise avatar Nov 26 '23 20:11 izissise

Ah yeah, this sucks. I think this is a little awkward to change unfortunately. I think this is a hacky way to trigger the visibility check, as we don't do it on a normal parse. Definitely room for improvement here, but seems quite low priority for us right now.

Tatskaari avatar Dec 01 '23 13:12 Tatskaari