Please plugins don't work when using BuildFileName

[cbwl]

I've recently begun trying to use the go-rules plugin in place of the built-in go rules as the direction of travel seems to be that the built-in rules will get replaced with the plugin model in future (correct me if I'm wrong!).

There seems to be an issue using plugins when a project is configured to use a different BuildFileName; in my repo we are using BuildFileName = BUILD.plz, and when I add the plugin and the subinclude("///go//build_defs:go") to my build file, I get the following error while building:

❯ plz build //third_party/go:all

Build stopped after 1.1s. 1 target failed:
    ///go//build_defs:go
//third_party/go:all depends on ///go//build_defs:go, but there's no BUILD.plz file in plz-out/subrepos/please/plugins/go/build_defs/

I think, based on the .plzconfig of the plugin, that this should really be looking for a BUILD file within the subrepo, not a BUILD.plz file.

This looks to be a duplicate of #1436, but I don't know that there was any resolution when it was raised there.

[Tatskaari]

Ah, i think this one slipped us by. I did think of this but it didn't seem to affect us (Thought Machine) in any way. We have a ticket here that was automatically closed: https://github.com/thought-machine/please/issues/2116

Sounds like we might need to get this done before we release v17 as i imagine others might fall afoul of this issue...

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions.

[samwestmoreland]

This is still an issue