please icon indicating copy to clipboard operation
please copied to clipboard

`java_library`: output JNI headers generated by `javac`

Open chrisnovakovic opened this issue 3 years ago • 2 comments

The Java compiler outputs header files for Java sources that use the Java Native Interface (JNI), but there's currently no way for them to be consumed by the native-code components that depend on them, preventing them from being built.

Provide the JNI headers as outputs of java_library when cc_hdrs is required. This allows native-code JNI components written in C/C++ to be built by including the java_library target as a dependency.

chrisnovakovic avatar Aug 06 '22 23:08 chrisnovakovic

Thanks! Would you mind please opening this against https://github.com/please-build/java-rules instead? Those plugin repos are where future development of language-specific rules will happen.

I have a couple of comments too but let's pick the conversation up there :)

peterebden avatar Aug 08 '22 08:08 peterebden

Thanks! Would you mind please opening this against https://github.com/please-build/java-rules instead? Those plugin repos are where future development of language-specific rules will happen.

I have a couple of comments too but let's pick the conversation up there :)

Will do - I noticed a couple of CI failures in here that I didn't see over there, so I'll fix those, then force-push equivalent changes to https://github.com/please-build/java-rules/pull/13.

chrisnovakovic avatar Aug 08 '22 15:08 chrisnovakovic

This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions.

stale[bot] avatar Nov 09 '22 10:11 stale[bot]