core icon indicating copy to clipboard operation
core copied to clipboard

[3pt] Move away from setuptools and use pyproject.toml instead

Open fridex opened this issue 3 years ago • 13 comments

Is your feature request related to a problem? Please describe.

As Thoth, I would like to get rid of setuptools and start using pyproject.toml-based projects as that's how Python community is shifting.

Acceptance criteria

  • [ ] Configure setuptools bit in pyproject.toml.
  • [ ] Set only release bits in setup.py
  • [ ] start with the repo https://github.com/thoth-station/thamos
  • [ ] Replicate in All repositories currently using setup.py and pyproject.toml

fridex avatar Dec 06 '21 11:12 fridex

/assign @fridex to refine a bit more, especially by providing a list of acceptance criteria referencing all the parts/components that would be impacted

codificat avatar Dec 21 '21 15:12 codificat

/triage needs-information

codificat avatar Dec 22 '21 11:12 codificat

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta avatar Jul 16 '22 18:07 sesheta

/remove-lifecycle rotten /sig stack-guidance /priority backlog

mayaCostantini avatar Jul 16 '22 20:07 mayaCostantini

/good-first-issue

mayaCostantini avatar Aug 08 '22 12:08 mayaCostantini

@mayaCostantini: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sesheta avatar Aug 08 '22 12:08 sesheta

See https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

mayaCostantini avatar Aug 08 '22 12:08 mayaCostantini

/triage accepted /priority important-soon

mayaCostantini avatar Aug 08 '22 12:08 mayaCostantini

this might help: https://dephell.readthedocs.io/

VannTen avatar Aug 18 '22 09:08 VannTen

I think we should turn this into a tracker issue, and open an issue on each of our repositories we care about. The individual tasks are not hard, but it's take time. This is typically the type of stuff which could be done in hacktoberfest, but for that we need to break it up into manageable chunks, and per repo seems the easiest.

I can script the issue creation without too much trouble I think.

@goern

VannTen avatar Sep 21 '22 10:09 VannTen

I can script the issue creation without too much trouble I think. @goern

please go ahead :)

goern avatar Sep 22 '22 07:09 goern

For now I put repos with a setup.py and no pyproject.toml. There is other (both presents for example), but that should the easiest ones.

  • [ ] https://github.com/thoth-station/aicoe-ci-pulp-upload-example/issues/24
  • [ ] https://github.com/thoth-station/thoth-pre-commit-hook/issues/34
  • [ ] https://github.com/thoth-station/invectio/issues/165
  • [ ] https://github.com/thoth-station/analyzer/issues/311
  • [ ] https://github.com/thoth-station/amun-client/issues/155
  • [ ] https://github.com/thoth-station/termial-random/issues/8
  • [ ] https://github.com/thoth-station/jupyter-nbrequirements/issues/338
  • [ ] https://github.com/thoth-station/kebechet/issues/1148
  • [ ] https://github.com/thoth-station/common/issues/1287
  • [ ] https://github.com/thoth-station/srcops-testing/issues/270
  • [ ] https://github.com/thoth-station/thamos/issues/1174
  • [ ] https://github.com/thoth-station/package-extract/issues/496

If someone can add this to the issues desc...

VannTen avatar Sep 26 '22 11:09 VannTen

Might be relevant (possible way to script the translation): https://stackoverflow.com/a/73830494

VannTen avatar Sep 28 '22 13:09 VannTen