adviser icon indicating copy to clipboard operation
adviser copied to clipboard

[3pt]Provide a generic advise_manifest_changes in results that can be retrieved and used by thamos

Open pacospace opened this issue 4 years ago • 7 comments

It might be good to provide a generic mechanism for this advised_manifest_changes so we can generalize the feature. Something like (rough design just to show the functionality):

advised_manifest_changes:
 - file: .thoth.yaml  # File that should be patched (can be also a buildconfig or so).
   patch:
     add: ...

Originally posted by @fridex in https://github.com/thoth-station/thamos/issues/910#issuecomment-942307322

Related-To: https://github.com/thoth-station/core/issues/308 Related-To: https://github.com/thoth-station/thamos/issues/910 Related-To: https://github.com/thoth-station/prescriptions-refresh-job/issues/87

pacospace avatar Dec 14 '21 14:12 pacospace

/kind bug /priority important-soon

goern avatar Dec 21 '21 11:12 goern

/kind bug /priority important-soon

It's actually a feature request :)

pacospace avatar Dec 21 '21 13:12 pacospace

hey @fridex do you want me to work on this?

pacospace avatar Jan 17 '22 10:01 pacospace

hey @fridex do you want me to work on this?

Feel free to take it. It is not clear to me how a good integration should look like though (and if we should directly support something like this now).

fridex avatar Jan 17 '22 10:01 fridex

/assign @mayaCostantini /sig stack-guidance /lifecycle active

mayaCostantini avatar Mar 16 '22 14:03 mayaCostantini

/remove-lifecycle active

mayaCostantini avatar Apr 19 '22 12:04 mayaCostantini

/priority backlog

VannTen avatar Oct 20 '22 10:10 VannTen