adviser icon indicating copy to clipboard operation
adviser copied to clipboard

[5pt]Enhance environment markers with python_version taken from package metadata

Open fridex opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe.

Pipenv added a new feature where each dependency has the environment marker python_version taken from package metadata. It might be a good idea to include such an environment marker in Thoth's adviser as well. It will not affect the resolution process anyhow, but will create more explicit Pipfile.lock with relevant python_version environment markers.

Describe the solution you'd like

  • [ ] sync information about python_version into the database from solver runs
  • [ ] propagate python_version information in a form of an environment marker in the resulting lock file

Describe alternatives you've considered

Keep the solution as-is.

fridex avatar Nov 01 '21 20:11 fridex

This would be a nice feature, but not "must-have". This behavior is partially documented. If users use overlays properly and have their environments setup correctly, this feature has no effect.

/priority backlog /triage accepted /sig adviser

fridex avatar Nov 01 '21 20:11 fridex

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta avatar Jan 30 '22 21:01 sesheta

/remove-lifecycle stale

fridex avatar Jan 31 '22 09:01 fridex

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta avatar Jun 01 '22 00:06 sesheta