fermentrack
fermentrack copied to clipboard
thorrak
Add your brewery icon
Place to stash a brewery icon so it shows on the page. Not essential but part of the showoff to your mates factor
That makes sense. Upper left. Followed by brewery name. If in upper left you could make it one size followed by name
I have this enhancement fleshed out and working in a production Fermentrack environment. The question is, where would you like placement of the logo? Would you want the user to display any image size they want. Would you want it above or below the Nav Bar?
Playing around with locations, I found the most visually appealing to be in the center, just under the Nav Bar. I do have the image restricted on display only because any image with a vertical size greater than 160px really starts to push your Devices and Gravity Sensors down the page.
(The image above the Nav Bar is a static image. Banners look very nice above the Nav Bar, but most users would not be creating their image in such a manner.)
If I can make a suggestion:
What I did with BrewPi Remix is check to see if something like "custom_logo.png" was in the root. If so, use that as the logo. This allowed updates to pull down any changes to the generic logo without breaking the customization.
While you could get REALLY fancy with CSS customization, my recommendation would be to define "a square logo of at least 150 x 150" (or something similar) and let the user mess with it if they choose to deviate from that.
Love the work you've done there @Garzlok!
Actually, part of this is already done. I use the Fermentrack Logo as a Placement/default logo. If you “click on” the logo it takes you to fermentrackIP/images. If you haven’t uploaded an image, instructions are included. If you’ve uploaded an Image(s), this page will display a list of your images.
@lbussy took your idea and ran with it...
Though I planned on css to control the Logo Image, I decided to create it's own .css file, named user_upload.css Though I know the whole idea of Cascading Style Sheets is NOT to have a dozen of them to call, I thought having a specific .css that a user could "hopefully" identify and utilize would be beneficial.
My experience reading through the RaspberryPints Thread, individuals are always asking how to control certain elements. Or how to fix something if they screw it up. If I placed the styling in one of the Minimal CSS's, that would be certain to happen.
Not having ANY basis for making a call on this (never looked at what's already there) that sounds reasonable. Give people repeatable and specific things which they can customize.
Just sitting here, musing after drinking a nice bourbon: I wonder if reversing the order of CSS application would help enforce that? Like, allow someone to specify a given customization, but wipe it out again or override parts of it if they try to extend it too far?
"Like, allow someone to specify a given customization, but wipe it out again or override parts of it if they try to extend it too far?" ...Uhh, mmm....I was told that this was an entry level position. :D
"Not having ANY basis for making a call on this"...oh, I understand that, I do feel pretty special that a Fermentrack Branch was named after me (or at least my handle). Thank goodness my real name wasn't used, because then I would feel like Special Ed. (Stephen Lynch: Special Ed. Google if you haven't heard it before)
This is more of an FYI, but as of 12/17/20, I've been successful merging your Dev Branch into my branch with these changes and nothing's broke.....yet. (I know you have other implementation/distribution concerns with the PRs)
#475 #476