Jade Michael Thornton
Jade Michael Thornton
This is interesting, I would never have thought of this! Some concerns: - I don't think this makes sense to be something that is generated by default, maybe it would...
I like `qrcode-terminal` a lot better! I have some other small comments I'll add but I'm on board with getting this added!
So, all the tests are failing in the same way, but without an obvious error message that I can see :(
Do you know what browsers do this and/or why?
This seems like a good addition, I don't have time to work on it right now but would love a PR from anyone!
I'd consider this a breach of the principle of least astonishment, request headers should be forwarded
How did you verify that `process.env.PORT` is set correctly?
For some reason GH isn't giving me the option to approve, could you maybe try merging master again?
Yeah this should be internal to http-server now. I'd gladly take a look at a PR implementing this!
Could you provide the full details about your environment? Especially the exact command(s) used, the http-server version, and also in this case, it would be helpful to see the output...