Bill Thornton

Thanks for the review @hdavidkim! I will try to look over this today.

I think this is not necessary since https://github.com/jellyfin/jellyfin-web/pull/5276 was merged... and we do explicitly include the vscode config for the project in the repo. :upside_down_face:

👍 I like the direction of both PRs. Using the "dangerous" prop was never intended to be a long term solution. We should probably also migrate to using the react-router...

We should review the order of sections on this page with Erik before making changes.

I was mainly questioning the potential overlap of the "bubble" code, so that explanation makes sense. :+1:

This seems to be a duplicate of https://github.com/jellyfin/jellyfin/issues/9208. The save button is only there to apply password changes. Profile picture updates happen immediately when you upload a new picture. You...

An admin changing their own password should require the old password to be entered... that part sounds like a server bug possibly. As far as making it clear that changing...

I double checked and it doesn't seem like that fix was backported to 10.8. It should be fixed in master/unstable though.

Sounds like https://github.com/jellyfin/jellyfin-web/issues/5041 but that was only present in unstable

We should hide the tab by default and show it if trailers are available. Plugins can provide trailers to make this work,so we should not remove it entirely.