Georgii Dolzhykov

icon indicating a website link http://www.comindwork.com

icon location Kyiv, Ukraine

Results 297 comments of Georgii Dolzhykov

Re-enable error recovery for contextual keywords used as identifiers

https://github.com/prettier/prettier/blob/main/CONTRIBUTING.md#tests

Angular parser with --write does not fix the issue, adds a line break each time it is run

Can be reproduced on the playground with `--embedded-language-formatting off`: **Prettier 2.7.1** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAeAJgSwG4D4A6UAFMMEkgAQCGNtd99AdAEatvsceNg+9--9G6YSNFixFAL6SAlIVQB6LHkIgANCAgAHGJmgBnZKCoAnExADuABVMJDKKgBsLVAJ6GNzE1TABrODAAylQAtnAAMphQcMgAZk76cJ7efgGBWj5RAObIMCYArkkgcCHMcMLl4VRQWflUWXAAYhAmIVQwujXImrGx6iAAFjAhjgDqA5jw+hlgcIF2kziTrt1g+h4gUYkmMFbeWW1xCUUAVvoAHoHZjnAAivkQ8EeOiRoZJtvd1bWOpv1aJiiMFGmHQMAGyAAHAAGN7mRKjbxaboAuDbbAxDQARwe8D22nsICo+gAtNFyuV+iY4DjMNS9vVDkh4i8iokQphcgU2dc7riYszjhoYFRmCCwRCkAAmYXeTCObIAYQgISZxX0AFZ+vlEgAVUX2FmvEDYQoASSg6AQQTAgJ0AEFLYEYK4bs9EtIgA) ```sh --parser angular --embedded-language-formatting off ``` **Input:** ```html ({{:: aaaaaaaaaaaaaaaaaaaa.bbbbbbbbbbbbbbbbbbbb.cccccccccccccccccccc.dddddddddddddddddddd }}) ``` **Output:** ```html ({{:: aaaaaaaaaaaaaaaaaaaa.bbbbbbbbbbbbbbbbbbbb.cccccccccccccccccccc.dddddddddddddddddddd }})...

Prettier takes 60+ seconds to run on an 800 line markdown file

It's the `trim` module used by remark that causes that. Patching that module to use the native `trim` method fixes this issue.

Prettier takes 60+ seconds to run on an 800 line markdown file

Yes, I just edited that module directly in node_modules and the issue was gone

Markdown: Preserve code blocks within list items

This is still a bug though, and it should be fixed by updating remark

Don’t multi-line imports (let them take less space) / Conflict with VSCode’s organizeImports

@phaux To solve this, I'd recommend running `organize-imports-cli` before Prettier as a pre-commit hook (e.g. using `lint-staged`).

Don’t multi-line imports (let them take less space) / Conflict with VSCode’s organizeImports

@lffg I wrote "before Prettier".

Don’t multi-line imports (let them take less space) / Conflict with VSCode’s organizeImports

How exactly does what I wrote prevent you all from running Prettier on save?

Don’t multi-line imports (let them take less space) / Conflict with VSCode’s organizeImports

Ah, I see now. You don't realize that I was answering to a specific comment (https://github.com/prettier/prettier/issues/5995#issuecomment-557749716). If the problem is "organize imports and Prettier are fighting each other", then the...

Add diff in output of --check (for CI use cases)

The message contains the file names. What else do you need to run Prettier on those files? `¯\_(ツ)_/¯`