asgardex-electron icon indicating copy to clipboard operation
asgardex-electron copied to clipboard

Support Electron build for Apple M1 computers

Open veado opened this issue 4 years ago • 2 comments

veado avatar Apr 07 '21 11:04 veado

No luck so far, CI of PR #1272 is still failing with following error:

 In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/sys/errno.h:72:
    /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/sys/cdefs.h:807:2: error: Unsupported architecture
    #error Unsupported architecture

^ https://github.com/thorchain/asgardex-electron/runs/2287174659?check_suite_focus=true#step:10:259

What we've tried so far:

  • Changed target of build (a6add3a889a6e39564201645e0d4b32df2897e00 + 9f44a69a4be4cd4ac02aa847946dff5b9a69fe85)
  • Changed artifact names (b97f3a40a380e7d499eccc4dcd102e7b1b042113)
  • Updated to latest python3 (bf51f15e87cb6f997a3a089796cd41cb7528a153 + 53ecedd1f3a4dcd69f81f8d5a1f03542b7ddd301)
  • Set -arch x86_64 (ccdfb723eba93f3925315d892eed9fb4f7306713)

Another solution might be to use another packager, such as Electron Forge or Electron Packager and / or electron-prebuild. However, it will take some time to switch and to do more testing. That's why we have decided to postpone support of Apple M1 computers. There is still a way for running ASGDX on M1 machines using Rosetta 2.

veado avatar Apr 08 '21 13:04 veado

Build looks like it's failing compiling usb for M1 on x86 runner. There are no pre-built node-usb packages available for v1.6.3 arm64 (https://github.com/tessel/node-usb/releases/)

The macos-latest target in build.yml runs macOS v10.15 (Catalina). The latest is v11.2 (Big Sur) which is what M1 runs on.

I suspect changing the runner from macos-latest to macOS-11.0 could fix. Worth a shot anyway.

Gitlab CI runners docs here: https://github.com/actions/virtual-environments regarding macos-11.0 (They both run Node v14.16.0)

HildisviniOttar avatar Apr 12 '21 10:04 HildisviniOttar