Thomas Thomassen comments

Results 573 comments of


                                            Thomas Thomassen

Sketchup.temp_dir returns short names on windows

Yea, I agree, it wasn't an ideal case for the SketchUp API. Unfortunately there wasn't any good alternative at the time. (Nor at this time for that matter.)

Sketchup.temp_dir returns short names on windows

We ship what the Ruby project provide. We don't want to be patching Ruby as that causes more work when we update. If anything I'd recommend anyone interested providing a...

Sketchup.temp_dir returns short names on windows

For the record here is (one of) the issues on this topic in the Ruby bug tracker: https://bugs.ruby-lang.org/issues/12650

ComponentDefinition#save_copy changes the guid if #path is not empty

> But why would calling save_copy also change the guid? (But only for components that have an associated path set) That doesn't sound right to me either. 🤔

Not working with ASCII .stl files. Only works well with Binary .stl files

ASCII is supported as well as binary: https://github.com/SketchUp/sketchup-stl/blob/main/src/sketchup-stl/importer.rb#L256 Do you have a sample STL file? And what SketchUp version and OS are you using? Are you seeing any errors in...

Empty Geom::BoundingBox instance methods return strange point objects

Hm... What version of SketchUp is this observed in?

Empty Geom::BoundingBox instance methods return strange point objects

I see it as far back as SU2014 (didn't try any further). Wonder if it could be uninitialized variables... Logged as SU-38425

C++ compile warnings

> we have a similar amount of warnings for gcc if we do `-DENABLE_WERROR` for all sources. currently we only check a subset of sources for most warnings, for exactly...

C++ compile warnings

> > Could potentially turn some of these warnings off by default, when ENABLE_COMPILER_WARNINGS is not enabled? > > At least as a short term thing? > > ENABLE_COMPILER_WARNINGS is...

C++ compile warnings

So would a PR that turn of the worst offenders in MSVC be accepted? As a short term fix?