django-more-admin-filters icon indicating copy to clipboard operation
django-more-admin-filters copied to clipboard

Add choices filters

Open 1vank1n opened this issue 4 years ago • 4 comments

Hi @thomst!

Thanks for your app. I offer add two classes for choices. Main difference with MultiSelectFilter that in filter correct display name, not value.

1vank1n avatar Apr 02 '21 09:04 1vank1n

add support Django 3.2

1vank1n avatar May 07 '21 07:05 1vank1n

Hi @1vank1n Thanks a lot for your contribution. Your filter classes seems to work well and are a good enhancement. But there are several problems with your pull request:

  • The tests doesn't work with django-3.2. So we cannot simply add django-3.2 support without addressing the issues of failing tests.
  • You didn't add any tests for the new filter classes which leads to a decreasing coverage of ~17%.

So would you either remove the django-3.2 support in your pull request or fix the tests and if neccessary the code for django-3.2? And do you have the ressources to add some tests for your filter classes? It might be done in a similar way as the tests for the existing ones.

Again. Thanks a lot.

thomst avatar May 28 '21 06:05 thomst

Hi @thomst!

I'll add tests in couple days.

1vank1n avatar May 28 '21 07:05 1vank1n

I tried this and It did not display anything for added filters. Django 3.2.4

1oglop1 avatar Sep 07 '21 11:09 1oglop1