django-more-admin-filters
django-more-admin-filters copied to clipboard
Add choices filters
Hi @thomst!
Thanks for your app. I offer add two classes for choices. Main difference with MultiSelectFilter that in filter correct display name, not value.
add support Django 3.2
Hi @1vank1n Thanks a lot for your contribution. Your filter classes seems to work well and are a good enhancement. But there are several problems with your pull request:
- The tests doesn't work with django-3.2. So we cannot simply add django-3.2 support without addressing the issues of failing tests.
- You didn't add any tests for the new filter classes which leads to a decreasing coverage of ~17%.
So would you either remove the django-3.2 support in your pull request or fix the tests and if neccessary the code for django-3.2? And do you have the ressources to add some tests for your filter classes? It might be done in a similar way as the tests for the existing ones.
Again. Thanks a lot.
Hi @thomst!
I'll add tests in couple days.
I tried this and It did not display anything for added filters. Django 3.2.4