traefik-forward-auth icon indicating copy to clipboard operation
traefik-forward-auth copied to clipboard

Multiple AUTH_HOST support

Open adyanth opened this issue 3 years ago • 11 comments

Allows support for using multiple AUTH_HOSTs Fixes #115

adyanth avatar Feb 18 '22 22:02 adyanth

Hey @thomseddon if you can confirm if this approach works, I can add a couple more test cases for the multi AUTH_HOST scenario.

adyanth avatar Feb 18 '22 22:02 adyanth

Can confirm this works, using it in my own setup with k3s + Traefik.

adyanth avatar Mar 17 '22 09:03 adyanth

@thomseddon any updates on getting this reviewed and merged in?

com6056 avatar Jun 02 '22 06:06 com6056

Great PR !

TBG-FR avatar Oct 27 '23 06:10 TBG-FR

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

ItalyPaleAle avatar Dec 11 '23 16:12 ItalyPaleAle

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

maxexcloo avatar Jan 19 '24 05:01 maxexcloo

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

Version 2 still has them! I recently updated to v3 which was a complete rewrite and changed a lot of things. Feel free to open issues and PRs :)

ItalyPaleAle avatar Jan 19 '24 05:01 ItalyPaleAle

Version 2 still has them! I recently updated to v3 which was a complete rewrite and changed a lot of things. Feel free to open issues and PRs :)

Issues seem to be disabled, mind enabling? I'll move this discussion there and maybe try to put in a PR (although I'm new to Go!)

maxexcloo avatar Jan 19 '24 05:01 maxexcloo

Version 2 still has them! I recently updated to v3 which was a complete rewrite and changed a lot of things. Feel free to open issues and PRs :)

Issues seem to be disabled, mind enabling? I'll move this discussion there and maybe try to put in a PR (although I'm new to Go!)

Done, I didn't realize they were disabled sorry

ItalyPaleAle avatar Jan 19 '24 15:01 ItalyPaleAle

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

@maxexcloo Support for allowlists (including domains for Google), has been re-added in 3.1.0: https://github.com/ItalyPaleAle/traefik-forward-auth/releases/tag/v3.1.0

ItalyPaleAle avatar Jan 21 '24 04:01 ItalyPaleAle

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

@maxexcloo Support for allowlists (including domains for Google), has been re-added in 3.1.0: https://github.com/ItalyPaleAle/traefik-forward-auth/releases/tag/v3.1.0

That’s absolutely amazing man! I haven’t been at my PC this weekend but I’ll be sure to give it a test tomorrow 👌

maxexcloo avatar Jan 21 '24 12:01 maxexcloo