cakephp-oauth-server icon indicating copy to clipboard operation
cakephp-oauth-server copied to clipboard

Refactor

Open rchavik opened this issue 11 years ago • 12 comments

This changeset refactor out the OAuth interface implementations into OAuthUtility. Leaving the component backward compatible (code-wise).

The next commit implements OAuthAuthenticate class that uses the interface in OAuthUtility. This class can be used to authenticate user by the access_token:

$this->Auth->authorize = array(
   'Form', // standard cakephp login forms
   'OAuth.OAuth', // by access_token in requests (Authorization header or access_token query string)
); 

Note: This class only authenticates requests. Authorization should be handled separately, either by Acl or Controller:isAuthorize()

Since this depends on the previous two PRs, actual diff is: 1913409d7c3c398f117f0d5f4053d7c144f4a983...ac4a4ca13699a1c5b8ddd4c5474df183769e516c

rchavik avatar Aug 21 '13 06:08 rchavik

I've just implemented a complete rewrite using a newer library that actually looks a lot like this - I will use your ideas here to package it as a plugin and push it up over the next few weeks - would be a nice v2.0

thomseddon avatar Jan 08 '14 14:01 thomseddon

Awesome. Definitely looking forward for the your new version.

Sorry about the inactivity on this repo. The project using this plugin has been put into the back burner and time is usually a problem (like everyone else).

rchavik avatar Jan 09 '14 00:01 rchavik

Absolutely no worries, there's no expectation for you to maintain it :)

Will get it done over coming weeks, will also try to start adding some tests!!

thomseddon avatar Jan 09 '14 11:01 thomseddon

@thomseddon When you say you are doing a rewrite does that mean you have a new oauth2-php library and will the implicit grant type be available?

iamdriz avatar Feb 09 '14 22:02 iamdriz

Yes it uses bshaffer's: https://github.com/bshaffer/oauth2-server-php and it does seem to have implicit grant.

I have started this but getting the required functionality into an authenticate object has proved a little tricky, I'm getting there though.

thomseddon avatar Feb 10 '14 08:02 thomseddon

@thomseddon Ah cool. Not to put any pressure on you as I think it's awesome you have taken the time to make this plugin, but do you have any indications for when it might be ready, just so I can scope out the project time scales roughly. Thanks pal :)

iamdriz avatar Feb 10 '14 11:02 iamdriz

It will probably take a few more weeks to get it out, sorry if it doesn't sit well with your schedules

thomseddon avatar Feb 10 '14 11:02 thomseddon

Few weeks will probably be fine :) However, I'm still confused about how the implicit grant type will offer the continuous logged in state that I'm achieving by using refreshTokens on the client side. Any chance you can offer some clarity on this: https://github.com/thomseddon/cakephp-oauth-server/issues/40 Thanks pal.

iamdriz avatar Feb 10 '14 12:02 iamdriz

How's this going? Any chance of a release soon? Thanks

iamdriz avatar Apr 18 '14 10:04 iamdriz

Hi thomseddon. How's the refactoring going? You had chance to launch a beta? Cheers

iamdriz avatar Jun 01 '14 09:06 iamdriz

Ich bin bis 02.06.2014 ausser Haus.

Die eMails werden nicht automatisch weitergeleitet.

Mit freundlichen Grüßen Stefan Mayr

I am out of office until 02nd of june 2014.

grizzly avatar Jun 01 '14 09:06 grizzly

Hi thomseddon,

Are you working on this?

Grtz Reijer

reijervano avatar Jun 12 '14 16:06 reijervano